fix: skip corrupted state.json in list_runs() instead of aborting

[Quratulain-bilal]

Problem

If any single state.json file is corrupted, truncated, or unreadable, the unhandled exception aborts the entire iteration and all subsequent valid runs are never listed.

Fix

Catch OSError, JSONDecodeError, and UnicodeDecodeError to skip bad entries gracefully.

Testing

• Verified that valid runs are still listed correctly
• Verified that a corrupted state.json is skipped without crashing

[Copilot]

Pull request overview

Updates workflow run discovery to skip unreadable or malformed state files instead of aborting.

Changes:

• Catches filesystem, JSON decoding, and Unicode decoding errors.
• Continues listing subsequent valid runs.

Show a summary per file

File	Description
src/specify_cli/workflows/engine.py	Adds fault tolerance when loading run state.

Review details

Tip

Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

Review details

Suppressed comments (2)

src/specify_cli/workflows/engine.py:748

• Removing the state_path.exists() call makes the load() explanation at lines 736–737—and the matching traversal-test explanation—stale because they still say that exists() probes the path. Update both descriptions to refer to the direct open/read performed here so the security rationale matches the implementation.

        try:
            with open(state_path, encoding="utf-8") as f:

src/specify_cli/workflows/engine.py:750

• The PR describes adding these exception catches to list_runs(), but that method's handler at line 1717 is unchanged and already catches JSONDecodeError, OSError, and UnicodeDecodeError. The only production change instead refactors RunState.load(), so this branch does not contain the stated fix. Please either apply the intended list_runs() change against the correct base, or revise the PR scope and remove or explain this unrelated refactor.

This issue also appears on line 747 of the same file.

        try:
            with open(state_path, encoding="utf-8") as f:
                state_data = json.load(f)
        except FileNotFoundError:

• Files reviewed: 2/2 changed files
• Comments generated: 0 new
• Review effort level: Balanced