fix: use incremental hashing in Preset.get_hash() - #3905
Open
Quratulain-bilal wants to merge 2 commits into
Open
fix: use incremental hashing in Preset.get_hash()#3905Quratulain-bilal wants to merge 2 commits into
Quratulain-bilal wants to merge 2 commits into
Conversation
…tire file into memory Preset.get_hash() called f.read() which loads the entire file into memory before hashing. Use incremental hashlib.sha256().update() with 64 KiB chunks to prevent unbounded memory allocation on large or maliciously sized preset files.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates preset manifest hashing to bound memory usage.
Changes:
- Streams files into SHA-256 using 64 KiB chunks.
- Preserves the existing hash format.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/presets/__init__.py |
Implements incremental preset hashing. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
| h = hashlib.sha256() | ||
| with open(self.path, 'rb') as f: | ||
| return f"sha256:{hashlib.sha256(f.read()).hexdigest()}" | ||
| for chunk in iter(lambda: f.read(65536), b''): |
…t_hash() Add test_get_hash_incremental_chunking that: - Creates a 200 KiB+ YAML manifest to force multiple 64 KiB chunks - Verifies the digest matches hashlib.sha256(content).hexdigest() - Rejects any unbounded f.read() call by patching builtins.open - Asserts at least 3 reads of <= 65536 bytes occurred
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Preset.get_hash()calledf.read()which loads the entire file into memory before hashing. A maliciously sized preset file could cause unbounded memory allocation.Fix
Use incremental
hashlib.sha256().update()with 64 KiB chunks.Testing