fix: eliminate TOCTOU race in yamlio.load_yaml() - #3909
Open
Quratulain-bilal wants to merge 2 commits into
Open
Conversation
Remove exists() pre-check and catch FileNotFoundError from read_text() to provide a clear BundlerError even under race conditions.
Contributor
There was a problem hiding this comment.
Pull request overview
Eliminates the TOCTOU race when loading YAML files.
Changes:
- Converts
FileNotFoundErrorintoBundlerError. - Removes the vulnerable existence pre-check.
- Missing a targeted regression test.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/bundler/lib/yamlio.py |
Handles deletion during file reads. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
Add regression test for the TOCTOU fix in load_yaml(). The mocked Path is observable as present (exists() returns True) but read_text() raises FileNotFoundError, proving the exists() removal eliminates the race window. Co-authored-by: GitHub Copilot (model: mimo-v2.5-free, supervised)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
yamlio.load_yaml()checksexists()then callsread_text(). The file can be deleted between the two calls, causing a rawFileNotFoundErrorinstead of the clearBundlerError.Fix
Remove the
exists()pre-check and catchFileNotFoundErrorfromread_text().Testing
BundlerErroris raised when file is missing