Repository navigation
Let short tables fill the prose width - #386
Open
MaggieAppleton wants to merge 1 commit into
Open
MaggieAppleton wants to merge 1 commit into
MaggieAppleton wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Hold — design decision for Maggie. This changes the layout of every existing short table; please don't merge until Maggie has decided. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A new table from
/Tableis a 3×3 grid at about half the prose width, and short authored tables do the same. The design audit (editor finding 13) asked for new tables to use the full width.What changed
packages/editor/src/styles.css). The rows sit in an anonymous table box that shrinks to fit its columns, so each column in a table of up to six asks for an equal share of the table's width through a container query (100cqi / N, where N comes from:has()on the row).Screenshots
Before: an authored table and a new table
After
Testing
bun run ci: passes, including the design contractbun run build: initial bundle unchanged at 246661 B🤖 Generated with Claude Code