Exclude Cargo target dir from wheel builds#334
Merged
Conversation
python-source = "." makes maturin walk the whole project tree when
collecting files for the wheel. The Rust crate lives inside the package
at gamdl/downloader/ammuxer, so its Cargo target/ dir (including the
output wheel maturin is writing into target/wheels/) gets pulled into
the wheel. Building from a git checkout is unaffected because .gitignore
excludes target/, but sdists do not ship .gitignore, so any source build
(e.g. pip install --no-binary :all:, distro packaging) recursively packs
the growing output wheel into itself and maturin aborts with:
Failed to write to zip archive for gamdl-3.8.3-...whl
Large file option has not been set
Add an explicit exclude so target/ is dropped regardless of .gitignore.
MDSVJ
approved these changes
Jul 14, 2026
glomatico
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python-source = "."pulls the crate'starget/(and the wheel being written) into the wheel itself→ 4 GiB zip error on sdist builds from homebrew build
.gitignoresaves git checkouts but isn't in sdists. One-lineexcludesorts it out.