fix(deps): remediate v1.2.0 dependency advisories - #220
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3149d2e4d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "vite": "^5.4.19", | ||
| "vitest": "^3.2.4" | ||
| "vite": "^6.4.3", | ||
| "vitest": "^4.1.11" |
There was a problem hiding this comment.
When a contributor uses the Node 18 environment supported by CONTRIBUTING.md:11, npm run test now invokes Vitest 4.1.11, whose committed lock entry requires Node ^20.0.0 || ^22.0.0 || >=24.0.0; the upgraded React Router package also requires Node 20 or newer. This makes the documented setup unsupported and causes engine-strict installs to fail, whereas the previous versions supported Node 18. Either retain patched dependency versions compatible with Node 18 or raise the documented prerequisite and declare the new Node requirement in package.json.
Useful? React with 👍 / 👎.
Summary
Validation
npm run check(325 frontend tests; 690 daemon tests)npm run test:e2e(26 passed)npm run test:e2e:installednpm audit --audit-level=lowcd daemon && bun audit --productionBoth dependency audits report zero known vulnerabilities.