Repository navigation
Use unique temporary files for atomic edits - #7
Closed
sylvesterkaczmarek wants to merge 1 commit into
Closed
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
pluskid
pushed a commit
that referenced
this pull request
Sep 16, 2026
Manual merge of external PR #7
Collaborator
|
Thank you! Manually merged in 7684e38 with authorship preserved. |
Contributor
Author
|
Thanks for merging this and preserving the authorship. Much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atomicWriteuses a fixed<path>.amplio.tmpname. Concurrent writes can overwrite or rename each other's temporary file, and an unrelated file with that name is overwritten and removed. A failed rename also leaves the temporary file behind.Create a unique temporary file in the destination directory, preserve the target's permissions, close before renaming, and clean up on every return path. This preserves last-writer-wins behavior; it does not add edit conflict detection.
Validation
go test -race ./internal/tool/editfile ./internal/tool/anchor ./internal/tool/viewfile: 79 tests passed. The three new atomic-write regressions fail on unpatched main and pass after the fix, including 30 repeated race-enabled runs.go vetfor those packages andgofmtpass. Tested on macOS; no Windows execution was performed.