fix(cli): single trailing newline on css-tailwind export#140
Open
drmikecrypto wants to merge 1 commit into
Open
fix(cli): single trailing newline on css-tailwind export#140drmikecrypto wants to merge 1 commit into
drmikecrypto wants to merge 1 commit into
Conversation
Use stdout.write because serializeTailwindV4 already ends with one newline; console.log added a second byte that broke git diff --check. Also exit cleanly on missing DESIGN.md with a friendly message instead of dumping a Node stack trace after the JSON error. Fixes google-labs-code#139 Fixes google-labs-code#132
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
drmikecrypto
force-pushed
the
fix/css-export-newline-and-missing-file
branch
from
cd8c7fa to
19c09c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use stdout.write because serializeTailwindV4 already ends with one newline; console.log added a second byte that broke git diff --check.
Also exit cleanly on missing DESIGN.md with a friendly message instead of dumping a Node stack trace after the JSON error.
Fixes #139
Fixes #132