Standardize content block handling in BuiltInPlanner.process_planning_response - #6561
Closed
guptaishaan wants to merge 1 commit into
Closed
Standardize content block handling in BuiltInPlanner.process_planning_response#6561guptaishaan wants to merge 1 commit into
guptaishaan wants to merge 1 commit into
Conversation
…_response Previously, `BuiltInPlanner.process_planning_response()` returned `None`, and `_NlPlanningResponse` worked around this with a special identity check (`type(planner).process_planning_response is BuiltInPlanner.process_planning_response`) to skip calling it entirely. This meant the `BuiltInPlanner` never participated in the standardized content-block pipeline that `PlanReActPlanner` uses. Signed-off-by: Ishaan <ishaangupta0408@gmail.com>
adk-bot
added
the
core
Collaborator
|
Close in favor of #6666 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
BuiltInPlanner.process_planning_response()returnedNone, and_NlPlanningResponseworked around this with a special identity check (type(planner).process_planning_response is BuiltInPlanner.process_planning_response) to skip calling it entirely. This meant theBuiltInPlannernever participated in the standardized content-block pipeline thatPlanReActPlanneruses.This change gives
BuiltInPlannera concrete implementation ofprocess_planning_response()that returns the model's native content blocks as-is. The model's thinking feature already marks reasoning parts withthought=True, so these parts already conform to the standardized block representation (analogous to{'type': 'reasoning', ...}blocks) without further transformation.With
BuiltInPlannernow providing a real implementation, the special-case bypass in_NlPlanningResponseis no longer needed and has been removed. Both planners now flow through the same response-processing path, making the overall design consistent.Fixes #3378