This repository was archived by the owner on Jan 20, 2026. It is now read-only.
setup stretch-slim base image to allow installing openjdk#241
Open
eighthave wants to merge 1 commit intogoogle:masterfrom
Open
setup stretch-slim base image to allow installing openjdk#241eighthave wants to merge 1 commit intogoogle:masterfrom
eighthave wants to merge 1 commit intogoogle:masterfrom
Conversation
The stretch-slim base image removes the man pages, docs, locales, etc. Some package install processes will fail if the dirs are not present, like /usr/share/man/man1. This includes default-jdk-headless, which someone would install if they wanted to run a gradle build in the Docker image before starting the emulator. The mkdir hack comes from: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863199
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
|
Would you mind signing the cla? That way we can merge it in |
Author
|
@googlebot I signed it! |
Author
|
I see you just refactored the Dockerfile template handling. I think it probably makes sense to just include these changes in the Dockerfile templates. I can't figure out which Docker base image it being used now though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stretch-slim base image removes the man pages, docs, locales, etc. Some package install processes will fail if the dirs are not present, like /usr/share/man/man1. This includes
default-jdk-headless, which someone would install if they wanted to run a gradle build in the Docker image before starting the emulator.The mkdir hack comes from:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863199
Here's an example of running a build in this image:
https://gitlab.com/eighthave/ci-images-emulator-kvm/-/jobs/1052060212