Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I signed the CLA, does it match on email address? |
|
We'll now have two places where dependencies will be specified, which means they will go out of sync. |
Yes there is, that would be a full-on python package with pyproject.toml and dropping the requirements.txt; I can do that instead if you'd rather. |
I'm not going to speak for everybody, but i think the most important mode of operations for that script is just that, |
|
Yes, the script would still be invocable directly in this approach; Also I can't see whether the tests in the tools are run in the CI; they might only be running for the bindings? |
|
Personally, i only ever used the script as a directly invocable script, and never ever installed it, etc. |
|
i really don't see the point in this. this script is a utility, not a python "project". |
|
Ok, back to the original suggestion: we can make the script installation and invocation easier with inline metadata, it becomes more direct to run with uv (no assumption of python in $PATH with numpy,scipy installed) |
|
I would think this is sufficiently self-contained to be okay. |
compare.pycurrently does not have an installation method outside of BAZEL, only a requirements.txt at the folder level; its shebang usespython3in the env, which assumes a python3 interpreter is set up with dependencies installed.Add inline script metadata to enable running the script with
uv.In conda (pixi), this enables running:
instead of: