dependabot: base image versions are not digest refreshes - #533
Merged
Merged
Conversation
The docker-digests group bumped python:3.12 to 3.14 and node:22 to 25 along with the digests (google#527). The Python SDK image cannot build on 3.14: py-libp2p 0.8 pins coincurve==21.0.0, which has no cp314 wheel and whose sdist build fails against current cffi. Node 25 is a Current release, not LTS. Ignore Python minor/major and Node major version updates for the docker ecosystem so the group carries what it is named for; a new interpreter line is a change someone makes on purpose, with the SDK matrix behind it.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Dependabot configuration in .github/dependabot.yml to ignore major and minor version updates for Python, and major version updates for Node. This ensures that SDK images track stable dependencies (such as py-libp2p pinning coincurve) and Node remains on an LTS line, while digest updates continue to flow. I have no feedback to provide as the changes are straightforward and well-documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#527 (docker-digests group) fails at the
sdkjob: along with the digests it bumpedpython:3.12-slim-bookworm→3.14andnode:22-bookworm-slim→25.Dockerfile.sam-sdk-pythoncannot build. py-libp2p 0.8 pinscoincurve==21.0.0, which has no cp314 wheel, and its sdist build fails (RuntimeError: Expected exactly one LICENSE file in cffi distribution, got 0).This tells dependabot to leave Python minor/major and Node major versions alone in the docker ecosystem, so the group only carries digest refreshes (golang, alpine, and the same python/node tags). Moving an interpreter line stays a deliberate change.
After this merges I'll
@dependabot recreate#527 so it drops the version bumps and keeps the golang/alpine digests.