Skip to content
This repository was archived by the owner on Sep 15, 2021. It is now read-only.

Initial release of the Google Analytics Admin API client library for Node.js#1

Merged
JustinBeckwith merged 1 commit intomasterfrom
preview
Jul 6, 2020
Merged

Initial release of the Google Analytics Admin API client library for Node.js#1
JustinBeckwith merged 1 commit intomasterfrom
preview

Conversation

@ikuleshov
Copy link
Contributor

No description provided.

@ikuleshov ikuleshov requested a review from JustinBeckwith July 6, 2020 20:32
@@ -1,2 +1 @@
# nodejs-analyticsadmin
Google Analytics Node.js client library source
Admin: Nodejs Client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to lift the template of what we kind of already have here:
https://github.com/googleapis/nodejs-vision/blob/master/README.md

"name": "@google-analytics/admin",
"version": "0.1.0",
"description": "Admin client for Node.js",
"repository": "googleapis/nodejs-admin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-fenster this isn't correct - is there a way to customize the repo in the gapic generator?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Naming is hard, we prefer not to play the guessing game - since we never regenerate package.json (we exclude it in synth.py) we just change this field manually once.

"build/src",
"build/protos"
],
"keywords": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-fenster same problem - these keywords only make sense themselves for cloud

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For keywords, we make some guesses but also hardcode a lot of cloud stuff: https://github.com/googleapis/gapic-generator-typescript/blob/master/templates/typescript_gapic/package.json#L13-L25 Again, not sure how to make it better for non-cloud users (again, just fix them manually and don't regenerate package.json).

@JustinBeckwith JustinBeckwith merged commit 4632b0d into master Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants