Skip to content
This repository was archived by the owner on Sep 15, 2021. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
# nodejs-analyticsadmin
Google Analytics Node.js client library source
Admin: Nodejs Client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to lift the template of what we kind of already have here:
https://github.com/googleapis/nodejs-vision/blob/master/README.md

10 changes: 10 additions & 0 deletions linkinator.config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"recurse": true,
"skip": [
"https://codecov.io/gh/googleapis/",
"www.googleapis.com",
"img.shields.io"
],
"silent": true,
"concurrency": 10
}
64 changes: 64 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
{
"name": "@google-analytics/admin",
"version": "0.1.0",
"description": "Admin client for Node.js",
"repository": "googleapis/nodejs-admin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-fenster this isn't correct - is there a way to customize the repo in the gapic generator?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Naming is hard, we prefer not to play the guessing game - since we never regenerate package.json (we exclude it in synth.py) we just change this field manually once.

"license": "Apache-2.0",
"author": "Google LLC",
"main": "build/src/index.js",
"files": [
"build/src",
"build/protos"
],
"keywords": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-fenster same problem - these keywords only make sense themselves for cloud

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For keywords, we make some guesses but also hardcode a lot of cloud stuff: https://github.com/googleapis/gapic-generator-typescript/blob/master/templates/typescript_gapic/package.json#L13-L25 Again, not sure how to make it better for non-cloud users (again, just fix them manually and don't regenerate package.json).

"google apis client",
"google api client",
"google apis",
"google api",
"google",
"google cloud platform",
"google cloud",
"cloud",
"google admin",
"admin",
"analytics admin service"
],
"scripts": {
"clean": "gts clean",
"compile": "tsc -p . && cp -r protos build/",
"compile-protos": "compileProtos src",
"docs": "jsdoc -c .jsdoc.js",
"predocs-test": "npm run docs",
"docs-test": "linkinator docs",
"fix": "gts fix",
"lint": "gts check",
"prepare": "npm run compile-protos && npm run compile",
"system-test": "c8 mocha build/system-test",
"test": "c8 mocha build/test"
},
"dependencies": {
"google-gax": "^2.6.1"
},
"devDependencies": {
"@types/mocha": "^7.0.2",
"@types/node": "^14.0.14",
"@types/sinon": "^9.0.4",
"c8": "^7.2.0",
"gts": "^2.0.2",
"jsdoc": "^3.6.4",
"jsdoc-fresh": "^1.0.2",
"jsdoc-region-tag": "^1.0.4",
"linkinator": "^2.1.1",
"mocha": "^8.0.1",
"null-loader": "^4.0.0",
"pack-n-play": "^1.0.0-2",
"sinon": "^9.0.2",
"ts-loader": "^7.0.5",
"typescript": "^3.9.5",
"webpack": "^4.43.0",
"webpack-cli": "^3.3.12"
},
"engines": {
"node": ">=10.0.0"
}
}
Loading