-
Notifications
You must be signed in to change notification settings - Fork 441
ci(v3): enable GHA for windows+cmake to debug kokoro #15924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: prepare-for-v3.0.0
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| # Copyright 2021 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| FROM ubuntu:22.04 | ||
|
|
||
| ENV DEBIAN_FRONTEND=noninteractive | ||
| RUN apt-get update && \ | ||
| apt-get --no-install-recommends install -y \ | ||
| automake \ | ||
| build-essential \ | ||
| clang \ | ||
| cmake \ | ||
| curl \ | ||
| gawk \ | ||
| git \ | ||
| gcc \ | ||
| g++ \ | ||
| cmake \ | ||
| libcurl4-openssl-dev \ | ||
| libssl-dev \ | ||
| libtool \ | ||
| lsb-release \ | ||
| make \ | ||
| ninja-build \ | ||
| patch \ | ||
| pkg-config \ | ||
| python3 \ | ||
| python3-dev \ | ||
| python3-pip \ | ||
| tar \ | ||
| unzip \ | ||
| zip \ | ||
| wget \ | ||
| zlib1g-dev \ | ||
| apt-utils \ | ||
| ca-certificates \ | ||
| apt-transport-https | ||
|
|
||
| # Install Python packages used in the integration tests. | ||
| RUN update-alternatives --install /usr/bin/python python $(which python3) 10 | ||
| RUN pip3 install setuptools wheel | ||
| # The Cloud Pub/Sub emulator needs Java :shrug: | ||
| RUN apt update && (apt install -y openjdk-11-jre || apt install -y openjdk-9-jre) | ||
|
|
||
| # Install the Cloud SDK and some of the emulators. We use the emulators to run | ||
| # integration tests for the client libraries. | ||
| COPY . /var/tmp/ci | ||
| WORKDIR /var/tmp/downloads | ||
| RUN /var/tmp/ci/install-cloud-sdk.sh | ||
| ENV CLOUD_SDK_LOCATION=/usr/local/google-cloud-sdk | ||
| ENV PATH=${CLOUD_SDK_LOCATION}/bin:${PATH} | ||
|
|
||
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.27.0/bazelisk-linux-${ARCH}" && \ | ||
| chmod +x /usr/bin/bazelisk && \ | ||
| ln -s /usr/bin/bazelisk /usr/bin/bazel |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 2025.10.17 | ||
| 3895230f38e498525f2560a281223d12066fa74a |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,7 @@ function cmake::common_args() { | |
| fi | ||
| local args | ||
| args=( | ||
| -DCMAKE_CXX_STANDARD=17 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Setting References
|
||
| -DGOOGLE_CLOUD_CPP_ENABLE_CCACHE=OFF | ||
| -DGOOGLE_CLOUD_CPP_ENABLE_WERROR=ON | ||
| -GNinja | ||
|
|
@@ -58,7 +59,7 @@ function cmake::common_args() { | |
| if [[ -n "${VCPKG_TRIPLET:-}" ]]; then | ||
| args+=("-DVCPKG_TARGET_TRIPLET=${VCPKG_TRIPLET}") | ||
| fi | ||
| args+=("-DVCPKG_OVERLAY_PORTS=ci/gha/builds/vcpkg-overlays") | ||
| args+=("-DVCPKG_OVERLAY_PORTS=ci\gha\builds\vcpkg-overlays") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| printf "%s\n" "${args[@]}" | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| diff --git a/cmake/opentracing-cpp.cmake b/cmake/opentracing-cpp.cmake | ||
| index f014ecd..fd8898a 100644 | ||
| --- a/cmake/opentracing-cpp.cmake | ||
| +++ b/cmake/opentracing-cpp.cmake | ||
| @@ -1,7 +1,11 @@ | ||
| # Copyright The OpenTelemetry Authors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| -find_package(OpenTracing CONFIG QUIET) | ||
| +find_package(OpenTracing CONFIG REQUIRED) | ||
| +if(NOT TARGET OpenTracing::opentracing AND TARGET OpenTracing::opentracing-static) | ||
| + add_library(OpenTracing::opentracing ALIAS OpenTracing::opentracing-static) | ||
| +endif() | ||
| + | ||
| set(OpenTracing_PROVIDER "find_package") | ||
|
|
||
| if(NOT OpenTracing_FOUND) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
-DNOMINMAXis a crucial step for Windows compatibility in C++ projects. This prevents conflicts between themin/maxmacros defined inwindows.handstd::min/std::maxfrom the C++ standard library, which can lead to unexpected compilation errors or behavior.