feat: add end-to-end checksumming for json resumable uploads #3445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
BenWhitehead
force-pushed
the
my/json/resumable/checksum
branch
from
8094e0b to
74259a5
Compare
If a crc32cMatch or md5Match are not specified when creating the resumable upload, a running checksum will be computed and included in the finalization call. * Add plumbing logic for capture/restore logic of BlobWriteChannelV2 * Add JsonResumableWrite hasher and cumulativeCrc32c to track the hasher and running checksum when necessary * Update JsonResumableSession to send cumulativeCrc32c when finalizing, and to update the running crc32c when a successful result is received * Add integration tests to ITJsonResumableSessionTest to verify checksum is sent and correctly computed, even when retried or partial consumed * Update Hasher.nullSafeConcat to be type dependent upon the left hand side provided type
BenWhitehead
force-pushed
the
my/json/resumable/checksum
branch
from
74259a5 to
02e9350
Compare
nidhiii-27
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Collaborator
|
Merged as part of Nidhi's PR. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a crc32cMatch or md5Match are not specified when creating the resumable upload, a running checksum will be computed and included in the finalization call.
X-Goog-Hashif present when an upload request fails