Skip to content

tests: refactor systests using pytest #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 54 commits into from
Jun 25, 2021
Merged

tests: refactor systests using pytest #476

tseaver merged 54 commits into from
Jun 25, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 23, 2021

Closes #475

Note to reviewers: this PR touches every bit of tests/system, splitting the monolithic tests/system/test_system.py into coherent pieces and refactoring them to use pytest fixtures. It is likely easiest to read commit-by-commit, at least until the pattern becomes clear.

tseaver added 30 commits June 23, 2021 12:59
@tseaver
tests: move systest for service acct email to new module
8a35175 
Refactor to use pytest fixtures

Toward #475.
@tseaver
tests: move systest for hmac keys to new module
44d70d0 
Refactor to use pytest fixtures

Toward #475.
@tseaver
tests: skip test if not service account
a08b702
@tseaver
tests: move test for 'Client.create_bucket' to new module
ffb140e 
Refactor to use pytest idioms.

Toward #475.
@tseaver
tests: move test for 'Bucket.create' to new module
e647017 
Refactor to use pytest idioms.

Toward #475.
@tseaver
tests: move test for 'Bucket.lifecycle_rules' to new module
ebfd433 
Refactor to use pytest idioms.

Toward #475.
@tseaver
tests: move test for 'Client.list_buckets' to new module
89edc92 
Refactor to use pytest idioms.

Toward #475.
@tseaver
tests: move test for updating 'Bucket.labels' to new module
6ce2487 
Toward #475
@tseaver
tests: move test for bucket get / set IAM policy to new module
f06706b 
Toward #475
@tseaver
tests: move test for bucket CRUD w/ requester pays to new module
244359c 
Toward #475
@tseaver
tests: move test for bucket ACL/IAM w/ requester pays to new module
269aebe 
Toward #475
@tseaver
tests: move test for 'Bucket.copy_blob' w/ requester pays to new module
7635f34 
Toward #475
@tseaver
tests: move test for 'Bucket.copy_blob' w/ generation_match to new mo…
476ec68 
…dule

Toward #475
@tseaver
tests: move test for 'Bucket.copy_blob' w/ metageneration_match to ne…
43604e4 
…w module

Toward #475
@tseaver
tests: move test for 'Bucket.get_blob' w/ user project to new module
459e4d3 
Toward #475
@tseaver
tests: make 'require_service_account' a fixture
14d5430
@tseaver
tests: add 'shared_bucket' fixture
f46f549
@tseaver
tests: move tests for large / samll file writes to new module
109ba48 
Toward #475
@tseaver
tests: make 'user_project' a fixture
9788a13
@tseaver
tests: rename 'require_service_account' fixture to 'service_account'
4a35440 
Make it return the actual credentials for use in testcases.
@tseaver
tests: move tests for blob CRUD to separate module
445ded8 
Toward #475
@tseaver
tests: move tests for blob ACL to separate module
06ef8e5 
Toward #475
@tseaver
tests: move more tests for blob write to separate module
d36da5f 
Toward #475
@tseaver
test: move conditional blob download tests to new module
4e5f4d5 
Toward #475
@tseaver
tests: move tests for download as URI to new module
6b1f81f 
Toward #475
@tseaver
tests: move test for 'Bucket.copy_blob' to new module
283ebc0 
Toward #475
@tseaver
tests: move test for 'Blob.download_as_text' to new module
d7d6e23 
Toward #475
@tseaver
tests: move test for upload of gzip-encoded file to new module
c6d25ec 
Toward #475
@tseaver
tests: move test for resumable upload w/ genration to new module
c2c193d 
Toward #475
@tseaver
tests: move remaining 'Blob.upload_from' tests to new module
a48acc9 
Toward #475
@tseaver tseaver requested review from a team, cojenco, frankyn and tritone June 23, 2021 17:04
@tseaver tseaver requested a review from a team as a code owner June 23, 2021 17:04
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jun 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2021
@tseaver tseaver force-pushed the 475-refactor-systests-using-pytest branch from 300e270 to 97fc701 Compare June 23, 2021 17:14
cojenco
cojenco reviewed Jun 25, 2021
View reviewed changes
cojenco
cojenco reviewed Jun 25, 2021
View reviewed changes
cojenco
cojenco reviewed Jun 25, 2021
View reviewed changes
@tseaver tseaver requested a review from cojenco June 25, 2021 15:19
cojenco
cojenco approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍 Thanks @tseaver for making the big move of splitting the system test. Appreciate the iterative approach and review tips. It was nice to follow commit-by-commit.

@tseaver
Copy link
Contributor Author

tseaver commented Jun 25, 2021 •
edited
Loading

Systests under Python 2.7 fail here because googleapis/python-test-utils#36: functools.wraps under Python 2.7 loses metadata wrapped functions, breaking pytest fixture injection.

Options:

@tseaver tseaver merged commit b20ca20 into master Jun 25, 2021
@tseaver tseaver deleted the 475-refactor-systests-using-pytest branch June 25, 2021 19:39
@tseaver tseaver mentioned this pull request Jul 21, 2021
Closed
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: refactor systests using pytest (googleapis#476)
9dcd8b9 
* Move systests from monolith to new, more focused modules.
* Refactor systests to use pytest fixtures.

Closes googleapis#475
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: refactor systests using pytest (googleapis#476)
9ce1e4c 
* Move systests from monolith to new, more focused modules.
* Refactor systests to use pytest fixtures.

Closes googleapis#475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cojenco cojenco cojenco approved these changes

@chrisrossi chrisrossi Awaiting requested review from chrisrossi

@tswast tswast Awaiting requested review from tswast

@andrewsg andrewsg Awaiting requested review from andrewsg

@frankyn frankyn Awaiting requested review from frankyn

@tritone tritone Awaiting requested review from tritone

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor systests to use pytest fixtures

2 participants

@tseaver @cojenco