-
Notifications
You must be signed in to change notification settings - Fork 16
chore: release #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: release #49
Conversation
Summary of ChangesHello @googleworkspace-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request facilitates the automated release of version 0.6.3 for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated release. The version bump and changelog update are correct. However, I've identified a high-severity issue in the underlying code change being released. The new OAuth scopes have not been correctly classified as sensitive, which undermines a key security feature of the tool. I've left a detailed comment on the CHANGELOG.md with a recommendation on how to resolve this before merging the release.
|
|
||
| ### Patch Changes | ||
|
|
||
| - 496529e: Add `https://www.googleapis.com/auth/script.container.ui` and `https://www.googleapis.com/auth/script.send_mail` to hardcoded scopes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The underlying change for this release (commit 496529e) appears to be incomplete. The newly added scopes, https://www.googleapis.com/auth/script.container.ui and https://www.googleapis.com/auth/script.send_mail, should be classified as 'sensitive' scopes. Currently, they are not, which means the linter will fail to warn users about their sensitivity.
According to Google's documentation, both of these scopes are sensitive.
Please create a new changeset to correctly classify these scopes in packages/vscode-extension/src/scopes.ts. This release PR will then be automatically updated to include the fix.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Patch Changes
https://www.googleapis.com/auth/script.container.uiandhttps://www.googleapis.com/auth/script.send_mailto hardcoded scopes.