Removed unnecessary variable initialization from discard method on so…#243
Open
RScrusoe wants to merge 1 commit intograntjenks:masterfrom
Open
Removed unnecessary variable initialization from discard method on so…#243RScrusoe wants to merge 1 commit intograntjenks:masterfrom
RScrusoe wants to merge 1 commit intograntjenks:masterfrom
Conversation
…rted sets We can avoid declaring _set variable and directly access self._set. For now doing this in discard method only. I can work on entire code base to remove unnecessary allocations, only in the places where this does not adversely affect the readability
|
At some point this should be done for the entire codebase, it impedes the readability of everything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rted sets
We can avoid declaring _set variable and directly access self._set. For now doing this in discard method only. I can work on entire code base to remove unnecessary allocations, only in the places where this does not adversely affect the readability