fix(magento-cart): own the CurrentCartId schema - #2673
Merged
paales merged 1 commit intoSep 22, 2026
Merged
Conversation
The file schema/CurrentCartId.graphqls was shipped by magento-compare, but everything in it belongs to the cart: Query.currentCartId, the CurrentCartId type and RegisterCartIdInput. magento-cart had no schema/ directory at all, even though its own hook queries currentCartId @client. The mesh only reads */schema/**/*.graphqls, so the cart only got its schema when magento-compare happened to be installed. That made an optional package required by the cart.
🦋 Changeset detectedLatest commit: 60b3b7e The changes in this PR will be included in the next version bump. This PR includes changesets to release 87 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@alohas is attempting to deploy a commit to the Reach Digital Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
magento-compareships a schema file that belongs tomagento-cart@graphcommerce/magento-compareshipsschema/CurrentCartId.graphqls. Everything inthat file belongs to the cart:
Query.currentCartId, theCurrentCartIdtype andRegisterCartIdInput. Meanwhile@graphcommerce/magento-carthas noschema/directoryat all, even though
magento-cart/hooks/CurrentCartId.graphqlqueriescurrentCartId @client.The mesh only reads
*/schema/**/*.graphqlsfrom installed packages (seepackages/cli/src/bin/mesh.ts). So the cart only gets its schema whenmagento-comparehappens to be installed. Compare looks optional — all four of its plugins are behind
ifConfig: 'compare'— but removing it breaks codegen, and the error points at apackage you did not touch:
I found this on 10.0.3 and checked the published npm tarballs, not just
node_modules,so it is not a local install problem. It is still there on
canaryat11.0.0-canary.47.This PR moves the file to
packages/magento-cart/schema/, so the cart carries its ownschema.
magento-compare/schema/keepsCurrentCompareUid.graphqls, which really isits own. The file contents do not change — it is just a move, plus a changeset.