Repository navigation
fix: keep the react entry from bundling the core - #323
Merged
Merged
Conversation
Mark every import external while building ./react so it shares the main entry. Size-limit fails CI if the copy returns. Co-authored-by: Cursor <cursoragent@cursor.com>
Size Limit 14 imports util.styleText, which Node 18 does not export. Co-authored-by: Cursor <cursoragent@cursor.com>
dsleepo
force-pushed
the
cursor/react-entry-share-core
branch
from
October 9, 2026 06:26
5e988ae to
07506bf
Compare
dsleepo
marked this pull request as ready for review
October 9, 2026 06:27
dsleepo
requested review from
Estasie,
catakot,
feelsbadmans,
gingerhead and
jigetus
as code owners
October 9, 2026 06:27
jigetus
approved these changes
Oct 9, 2026
catakot
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark every import external while building ./react so it shares the main entry. Size-limit fails CI if the copy returns.
Closes #322