Skip to content

Added FESpaces qualifier#193

Open
miguelmaso wants to merge 1 commit intogridap:masterfrom
miguelmaso:added-qualifier
Open

Added FESpaces qualifier#193
miguelmaso wants to merge 1 commit intogridap:masterfrom
miguelmaso:added-qualifier

Conversation

@miguelmaso
Copy link

Hi, thanks for maintaining the ecosystem of packages related to Gridap!

When using Gridap and related packages (Julia 1.12 and 1.13), I've seen the compilation warning

┌ GridapDistributed
│  WARNING: Constructor for type "FESpace" was extended in `GridapDistributed` without explicit qualification or import.
│    NOTE: Assumed "FESpace" refers to `<null>.FESpace`. This behavior is deprecated and may differ in future versions.
│    NOTE: This behavior may have differed in Julia versions prior to 1.12.
│    Hint: If you intended to create a new generic function of the same name, use `function FESpace end`.
│    Hint: To silence the warning, qualify `FESpace` as `<null>.FESpace` in the method signature or explicitly `import <null>: FESpace`.
└  

This PR explicitly qualifies/imports FESpace to avoid the warning. Please let me know if this is the preferred approach. Hope it helps

@JordiManyer
Copy link
Member

Huh, I wonder how long that has been there... I guess I should upgrade to Julia 1.12. Thank you for the catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants