Fix filtering problem on global filters

[basseche]

PR Summary

• When we have 2 generic filters.
• One of them becomes invalid (deleted)
• When we remove the remaining valid filter we should have all equipments.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a235a9aa-ac62-47e8-9241-5e5ea1162d10

📥 Commits

Reviewing files that changed from the base of the PR and between 370898b and 48a75c7.

📒 Files selected for processing (1)

• src/components/spreadsheet-view/spreadsheet/spreadsheet-content/hooks/use-spreadsheet-gs-filter.ts

---

📝 Walkthrough

Walkthrough

The change modifies the isExternalFilterPresent calculation in the spreadsheet filter hook to validate global filters through buildValidGlobalFilters() instead of checking array length, affecting how external filtering decisions are made in Ag-Grid.

Changes

Cohort / File(s)	Summary
Spreadsheet Filter Validation src/components/spreadsheet-view/spreadsheet/spreadsheet-content/hooks/use-spreadsheet-gs-filter.ts	Changed isExternalFilterPresent logic to derive from buildValidGlobalFilters(selectedGlobalFilters) instead of a simple selectedGlobalFilters.length > 0 check, causing external filter presence to depend on filter validation success rather than array length alone.

Suggested reviewers

• flomillot

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly addresses the main change: fixing a filtering problem with global filters, which matches the file modification and PR objectives.
Description check	✅ Passed	The description clearly explains the bug scenario and expected behavior, relating directly to the filtering issue being addressed in the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud