Adds Font option to all Sheet type labels (Part 1)#18488
Open
Godmartinz wants to merge 20 commits intogrokability:developfrom
Open
Adds Font option to all Sheet type labels (Part 1)#18488Godmartinz wants to merge 20 commits intogrokability:developfrom
Godmartinz wants to merge 20 commits intogrokability:developfrom
Conversation
marcusmoore
reviewed
Jan 27, 2026
Member
Author
Collaborator
Member
Author
Collaborator
Collaborator
|
You're already on it 💪🏾 |
Member
Author
marcusmoore
approved these changes
Jan 28, 2026
Member
|
Has this been checked with LTR and CJK? |
Member
Author
Member
Author
|
looks like there is an issue for RTL langs. working on it |
Member
Author
|
RTL languages dont seem to work on develop either 🤔 |
marcusmoore
approved these changes
Jan 28, 2026
Collaborator
marcusmoore
left a comment
There was a problem hiding this comment.
Looks good to me. The only other suggestion I have is wondering if the fonts should be in a constant somewhere to avoid using strings all over the place but it's not a big deal in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







This adds a label font options to all the Sheet type labels. You are able to choose between 4 fonts for your


labelanddata sourcefontsThis also corrects the layout of a few labels (
L4736_A,L6009_A, L7162_A, L7163_A)