Skip to content

Bundle agg v1.10.1-sixel (reads sixel from reviewed avt)#80

Merged
tig merged 1 commit into
mainfrom
claude/bump-agg-v1.10.1
Jun 6, 2026
Merged

Bundle agg v1.10.1-sixel (reads sixel from reviewed avt)#80
tig merged 1 commit into
mainfrom
claude/bump-agg-v1.10.1

Conversation

@tig

@tig tig commented Jun 6, 2026

Copy link
Copy Markdown
Member

Bumps the pinned agg fork from v1.9.0-sixel to v1.10.1-sixel for the interim release while the upstream avt sixel PR (asciinema/avt#26) is pending.

v1.10.1-sixel captures sixel in avt and reads it back via Vt::images() instead of re-parsing the byte stream, and carries the reviewed dirty-row marking and bounded canvas allocation. Updates DefaultAggVersion, the release downloader default, and the docs naming the pin.

Bump the pinned agg fork from v1.9.0-sixel to v1.10.1-sixel, which captures
sixel in avt and reads it back rather than re-parsing the byte stream, and
carries the reviewed dirty-row and bounded-allocation fixes. Updates the
download default, the release downloader, and the docs that name the pin.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a3d6ce827

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pkg/gif/download.go
// The fork (see aggReleaseRepo) ships sixel rendering; pinned here until that
// support lands in an upstream asciinema/agg release.
DefaultAggVersion = "v1.9.0-sixel"
DefaultAggVersion = "v1.10.1-sixel"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin a release that publishes agg binaries

With this version, fresh installs and release packaging try to fetch URLs such as https://github.com/tig/agg/releases/download/v1.10.1-sixel/agg-x86_64-unknown-linux-musl, but the v1.10.1-sixel release page currently only has the two source-code assets and that binary URL 404s. This means tuirec record auto-download fails for users without an existing agg, and GoReleaser's go run ./internal/release/downloadagg hook will fail before producing archives; either attach the expected platform binaries to this tag or keep the pin on a release that has them.

Useful? React with 👍 / 👎.

@tig tig merged commit 8abdff3 into main Jun 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant