Bundle agg v1.10.1-sixel (reads sixel from reviewed avt)#80
Conversation
Bump the pinned agg fork from v1.9.0-sixel to v1.10.1-sixel, which captures sixel in avt and reads it back rather than re-parsing the byte stream, and carries the reviewed dirty-row and bounded-allocation fixes. Updates the download default, the release downloader, and the docs that name the pin. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a3d6ce827
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // The fork (see aggReleaseRepo) ships sixel rendering; pinned here until that | ||
| // support lands in an upstream asciinema/agg release. | ||
| DefaultAggVersion = "v1.9.0-sixel" | ||
| DefaultAggVersion = "v1.10.1-sixel" |
There was a problem hiding this comment.
Pin a release that publishes agg binaries
With this version, fresh installs and release packaging try to fetch URLs such as https://github.com/tig/agg/releases/download/v1.10.1-sixel/agg-x86_64-unknown-linux-musl, but the v1.10.1-sixel release page currently only has the two source-code assets and that binary URL 404s. This means tuirec record auto-download fails for users without an existing agg, and GoReleaser's go run ./internal/release/downloadagg hook will fail before producing archives; either attach the expected platform binaries to this tag or keep the pin on a release that has them.
Useful? React with 👍 / 👎.
Bumps the pinned agg fork from v1.9.0-sixel to v1.10.1-sixel for the interim release while the upstream avt sixel PR (asciinema/avt#26) is pending.
v1.10.1-sixel captures sixel in avt and reads it back via Vt::images() instead of re-parsing the byte stream, and carries the reviewed dirty-row marking and bounded canvas allocation. Updates DefaultAggVersion, the release downloader default, and the docs naming the pin.