Repository navigation
fix(audio): support full MPEG Layer III sync header detection for MP3 - #165
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #91
Root Cause Analysis
Previously, matchers.Mp3 only matched ID3 tags (0x49 0x44 0x33) and MPEG-1 Layer III audio frames without CRC protection (0xFF 0xFB). However, MP3 audio frames can use other valid MPEG versions (such as MPEG-2 Layer III used for lower sample rates like 16, 22.05, 24 kHz, or MPEG-2.5) as well as CRC-protected frames (where the protection bit is set to 0). When an MP3 without an ID3 container begins directly with an MPEG-2 Layer III frame header (e.g., 0xFF 0xF3 or 0xFF 0xF2), matchers.Mp3 returned false, causing the file to not be detected as MP3.
Changes
Test Verification