Modernize iOS project settings#3
Merged
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
Pull request overview
Modernizes the repository’s sample Xcode projects to a consistent baseline so they open cleanly in current Xcode versions and share aligned Swift/iOS settings.
Changes:
- Normalized Xcode project metadata by setting
LastUpgradeCheck = 1500across updated projects. - Updated build settings to use Swift 5 language mode (
SWIFT_VERSION = 5.0) and a minimum iOS deployment target of13.0for older samples. - Updated
README.mdto document the new baseline and cleaned up minor formatting/whitespace.
Reviewed changes
Copilot reviewed 66 out of 66 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| WebViewExample/WebViewExample.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| WebViewApp/WebViewApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| WebImageApp/WebImageApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| WebContentApp/WebContentApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| ViewControllerApp/ViewControllerApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| UserDefaultsApp/UserDefaultsApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| UIViewControllerLifecycle/UIViewControllerLifecycle.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| TouchIDApp/TouchIDApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| TouchID/TouchID.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| Toolbar/Toolbar.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| ToDoList/ToDoList.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| TimesTableApp/TimesTableApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| TableViewSearch/TableViewSearch.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| TableViewExample/TableViewExample.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| TableViewApp/TableViewApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| TableApp/TableApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| TabExample/TabExample.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| TabBarApp/TabBarApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| SwitchScreens/SwitchScreens.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| SwipeGestureRecognizer/SwipeGestureRecognizer.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| SwipeAndShakeApp/SwipeAndShakeApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| SpeechRecognition/SpeechRecognition.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| SpeechApp/SpeechApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| Segues/Segues.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| README.md | Document the new “Modern baseline” and clean up formatting/whitespace. |
| QuickActionApp/QuickActionApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| PickerViewApp/PickerViewApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| NotificationCenter/NotificationCenter.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| NavigationMenuApp/NavigationMenuApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| NavigationBar/NavigationBar.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| MVVMApp/MVVMApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| MVCApp/MVCApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| MultipleViewControllers/MultipleViewControllers.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| MessageApp/MessageApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0 (including extension targets). |
| MapView/MapView.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| MapApp/MapApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| LaunchScreen/LaunchScreen.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| LanguageApp/LanguageApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| KronometreApp/KronometreApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| KlavyeyiKontrolEtme/KlavyeyiKontrolEtme.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| JsonApiApp/JsonApiApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| IntelligentImage/IntelligentImage.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| Images/Images.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| GestureRecogziner/GestureRecogziner.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| FindPrimeNumber/FindPrimeNumber.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| FindMyAge/FindMyAge.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| DownloadingWebContent/DownloadingWebContent.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| DelegateDataSaved/DelegateDataSaved.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| DatePickerViewApp/DatePickerViewApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| CustomKeyboardApp/CustomKeyboardApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0 (including keyboard target Swift setting). |
| CoreDataExample/CoreDataExample.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| ControllingTheKeyboard/ControllingTheKeyboard.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| Colors/Colors.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| CollectionViewExample/CollectionViewExample.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| CollectionViewApplication/CollectionViewApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck and bump iOS deployment target to 13.0 (project already aligned to Swift 5.0). |
| CollectionViewApp/CollectionViewApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| CocoaPodsApp/CocoaPodsApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| Calculator/Calculator.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| BombTimer/BombTimer.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| AutoLayoutProgrammatic/AutoLayoutProgrammatic.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| AutoLayoutExample/AutoLayoutExample.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| AutoLayout/AutoLayout.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| AudioSpeechRecognition/AudioSpeechRecognition.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| Animations/Animations.xcodeproj/project.pbxproj | Bump iOS deployment target to 13.0 and set Swift to 5.0 for build configurations. |
| AlertViewApp/AlertViewApp.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
| AlertProject/AlertProject.xcodeproj/project.pbxproj | Normalize LastUpgradeCheck, bump iOS deployment target to 13.0, set Swift to 5.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ## Modern baseline ✨ | ||
|
|
||
| - Swift language version: Swift 5 project setting across Xcode projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
*.xcodeproj/project.pbxproj) across the repo to setSWIFT_VERSION = 5.0for app and target build configurations.IPHONEOS_DEPLOYMENT_TARGETvalues to13.0so samples share a modern UIKit baseline.LastUpgradeCheck = 1500in project attributes where older values were present.README.mdto document the new "Modern baseline ✨" (Swift 5, iOS 13.0, tooling normalization) and cleaned up minor whitespace.Testing
git diff --checkto surface whitespace or merge issues and fixed trailing whitespace inREADME.md, which passed.plutil -lint $(find . -path '*/Pods/*' -prune -o -name project.pbxproj -print), which returnedOKfor each project.rg -n "SWIFT_VERSION = 4\.|IPHONEOS_DEPLOYMENT_TARGET = 11\.4|IPHONEOS_DEPLOYMENT_TARGET = 12\.[0-2];|LastUpgradeCheck = (0940|1000|1020)" -g 'project.pbxproj' --glob '!**/Pods/**'which returned zero matches.Codex Task