HF-238 - Review \"Integration with Angular\" guide and demo#1691
Merged
sequba merged 6 commits intoJun 9, 2026
Conversation
* Fix package-lock file * Docs: remove CodeSandbox embedded demos and add links to working exa,ples in Stackblitz (#1621)
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Low Risk** > Low risk documentation-only changes: adds new guide pages and adjusts VuePress sidebar navigation with no runtime or API impact. > > **Overview** > Adds three new AI-focused documentation pages: `ai-sdk`, `integration-with-langchain`, and `mcp-server`, describing how to use HyperFormula for deterministic spreadsheet computation in agent workflows. > > Updates the VuePress guide sidebar to surface these pages under **Integrations**, renames the section from *Framework integration* to *Integrations*, and moves the former *Overview* links into a new *About* section. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 54c541b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: GreenFlux <support@greenflux.us> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for hyperformula-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Performance comparison of head (210c1ac) vs base (79f2f15) |
sequba
requested changes
Jun 9, 2026
| ``` | ||
|
|
||
| Consume the service from a component and bind `values$ | async` in the template. Declare the component in your `AppModule` alongside `CommonModule`: | ||
| Consume the service from a component and bind `values$ | async` in the template. The component below is **standalone** (the default since Angular 17) and imports `CommonModule` directly, so it works without an `NgModule`. The structural directives `*ngIf` / `*ngFor` and the `async` pipe all come from `CommonModule`: |
Contributor
There was a problem hiding this comment.
I'd prefer the snippets here to use @for syntax instead of *ngFor (same as the Stackblitz demo). Let's make it look like modern Angular
sequba
approved these changes
Jun 9, 2026
sequba
requested changes
Jun 9, 2026
sequba
left a comment
sequba
left a comment
Contributor
There was a problem hiding this comment.
Please change PR base to develop
sequba
approved these changes
Jun 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1691 +/- ##
========================================
Coverage 97.16% 97.16%
========================================
Files 176 176
Lines 15322 15322
Branches 3356 3356
========================================
Hits 14887 14887
Misses 427 427
Partials 8 8 🚀 New features to boost your workflow:
|
✅ Deploy Preview for hyperformula-dev-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
GreenFlux
added a commit
that referenced
this pull request
Jun 9, 2026
Brings in one content-only commit that landed on develop: - d4195b5 HF-238 - Review "Integration with Angular" guide and demo (#1691) It touches `docs/guide/integration-with-angular.md`, which this PR migrated to `docs/src/content/docs/guide/integration-with-angular.md`. Git's rename detection auto-applied the develop-side edits to the new location — no conflicts. Pushes the merge so GitHub's `mergeable: CONFLICTING` flag recomputes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In short: the guide was rewritten to show the modern pattern (matching the demo) while preserving backward compatibility, with a clear split by Angular version.
How did you test your changes?
Types of changes
Related issues:
Checklist:
Note
Low Risk
Documentation-only changes to the Angular integration guide; no runtime or library code affected.
Overview
Rewrites the Integration with Angular guide into a version-tiered layout: a new modern Angular (v20+) path (signals,
inject(), OnPush,@if/@for,provideZonelessChangeDetection) and a preserved older path (BehaviorSubject+asyncpipe).The legacy example is updated for standalone components (
standalone: true,imports: [CommonModule]) and adds anNgModule-based subsection for Angular 13 and below. Sample sheet data in snippets changes from[1, 2, '=A1+B1']to[1, 4, '=A1+B1']. Provider scope and Cleanup notes now state they apply to both signal and RxJS variants.Reviewed by Cursor Bugbot for commit 210c1ac. Bugbot is set up for automated code reviews on this repo. Configure here.