Skip to content

Add OpenShift support to boundary-controller Helm chart - #27

Open
Rkabra7 wants to merge 4 commits into
mainfrom
ICU-18856
Open

Add OpenShift support to boundary-controller Helm chart#27
Rkabra7 wants to merge 4 commits into
mainfrom
ICU-18856

Conversation

@Rkabra7

@Rkabra7 Rkabra7 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds OpenShift support to the Boundary Controller Helm chart, following the same pattern as the worker chart.

Changes

  • Updated deployment.yaml, db-init-job.yaml, db-migrate-job.yaml, db-repair-job.yaml, and bootstrap-admin-job.yaml to omit fixed runAsUser and fsGroup when openshift.enabled=true, allowing OpenShift SCC to assign a valid UID.
  • Updated service.yaml to force the API service to ClusterIP on OpenShift.
  • Added route.yaml to create an OpenShift Route for the controller API (port 9200) when openshift.enabled=true.
  • Added the boundary.controller.route.api.name helper in _helpers.tpl.
  • Added the openshift configuration block (enabled: false by default) to values.yaml and values.schema.json.
  • Added values.openshift.yaml for OpenShift deployments.
  • Added 30 unit tests across existing test files, 12 Route tests, and an OpenShift smoke test (ocp-smoke-test.sh).

Notes

  • openshift.enabled defaults to false, so existing Kubernetes deployments are unaffected.
  • Validated on CRC (OCP 4.21.4): jobs complete successfully, pods run with OpenShift-assigned UIDs, the Route is accessible, and the API is healthy.
  • 134 unit tests passing with 0 failures.

Related

  • Issue:
  • Chart/Component:

Checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • Added/updated tests or validation steps (if applicable)

  • Verified local lint/validation

  • No breaking changes, or clearly documented

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@Rkabra7
Rkabra7 requested a review from a team as a code owner June 23, 2026 12:23
@github-actions

Copy link
Copy Markdown

Reliability Check(s) Results

Target Asset: boundary-controller-helm
Checks Executed: none

✅ All checks passed!

@Rkabra7
Rkabra7 force-pushed the ICU-18856 branch 8 times, most recently from ec2fdf9 to f2d55d7 Compare July 16, 2026 08:30

@MayukhSobo MayukhSobo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the OpenShift support changes. Template logic (security contexts, Route, Service type override) looks correct and is well covered by unit tests. Two things worth fixing before merge:

Comment thread .github/workflows/ci.yaml Outdated
Comment thread Makefile Outdated

@MayukhSobo MayukhSobo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One code-quality note to go with the earlier comments — small, not blocking.

Comment thread templates/deployment.yaml Outdated

@smayukh smayukh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please address the review comments.

@smayukh

smayukh commented Jul 31, 2026

Copy link
Copy Markdown

@Rkabra7 LGTM!

smayukh
smayukh previously approved these changes Jul 31, 2026
@Rkabra7
Rkabra7 force-pushed the ICU-18856 branch 5 times, most recently from e2dbb18 to 5af8320 Compare August 14, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants