Conversation
Reliability Check(s) ResultsTarget Asset: ✅ All checks passed! |
Rkabra7
force-pushed
the
ICU-18856
branch
8 times, most recently
from
July 16, 2026 08:30
ec2fdf9 to
f2d55d7
Compare
MayukhSobo
reviewed
Jul 28, 2026
MayukhSobo
left a comment
There was a problem hiding this comment.
Reviewed the OpenShift support changes. Template logic (security contexts, Route, Service type override) looks correct and is well covered by unit tests. Two things worth fixing before merge:
MayukhSobo
reviewed
Jul 28, 2026
MayukhSobo
left a comment
There was a problem hiding this comment.
One code-quality note to go with the earlier comments — small, not blocking.
smayukh
requested changes
Jul 28, 2026
smayukh
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please address the review comments.
…ity context helpers
|
@Rkabra7 LGTM! |
smayukh
previously approved these changes
Jul 31, 2026
Rkabra7
force-pushed
the
ICU-18856
branch
5 times, most recently
from
August 14, 2026 09:06
e2dbb18 to
5af8320
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds OpenShift support to the Boundary Controller Helm chart, following the same pattern as the worker chart.
Changes
Notes
Related
Checklist
I have documented a clear reason for, and description of, the change I am making.
Added/updated tests or validation steps (if applicable)
Verified local lint/validation
No breaking changes, or clearly documented
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.