Agent: replace existing auth headers during auto-auth re-authentication#32023
Open
debben wants to merge 4 commits into
Open
Agent: replace existing auth headers during auto-auth re-authentication#32023debben wants to merge 4 commits into
debben wants to merge 4 commits into
Conversation
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
debben
marked this pull request as ready for review
July 1, 2026 19:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a Vault Agent auto-auth bug where auth headers could accumulate on the shared API client across re-authentication cycles.
When an auth method returned headers (for example, Kerberos
Authorization), re-authentication reused the same client and appended header values each cycle. Over time, requests could include duplicate/stale header values, causing authentication failures.This change makes header handling explicit and safe:
Issue reference:
Testing
TestAuthHandler_HeaderNotDuplicatedOnReauthKRB_AP_ERR_SKEWRisk / Impact
PCI review checklist
Security controls impact: