audit: Fix missing request ID in audit log for help operations#32025
audit: Fix missing request ID in audit log for help operations#32025Flamefire wants to merge 4 commits into
Conversation
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
194339b to
f24ffd4
Compare
|
Hi there! Thanks for this fix. Please sign the CLA and ping me when that's done, so I can get this in front of engineers for review. :) |
|
@heatherezell Thought that went through already, done now |
|
@Flamefire It looks like you might have submitted a commit from either email or something else that GitHub doesn't see as connected to your GitHub account - can you take a peek? |
The handleHelp function in http/help.go didn't set an ID unlike all other handlers. This caused the request.id field to be silently omitted from audit log entries for all help operations (e.g. `vault path-help`), making it impossible to correlate request and response entries in the audit log.
06367e2 to
4b5f08d
Compare
|
What exactly are you referring to? All commits have the same email and all are with a GitHub registered email and shown as mine. |
The handleHelp function in http/help.go didn't set an ID unlike all other handlers.
This caused the request.id field to be silently omitted from audit log entries for all
help operations (e.g.
vault path-help), making it impossible to correlate request and response entries in the audit log.Fix this by setting that ID
Fixes #32026