Skip to content

audit: Fix missing request ID in audit log for help operations#32025

Open
Flamefire wants to merge 4 commits into
hashicorp:mainfrom
Flamefire:fix/help-audit-request-id
Open

audit: Fix missing request ID in audit log for help operations#32025
Flamefire wants to merge 4 commits into
hashicorp:mainfrom
Flamefire:fix/help-audit-request-id

Conversation

@Flamefire

@Flamefire Flamefire commented Jul 2, 2026

Copy link
Copy Markdown

The handleHelp function in http/help.go didn't set an ID unlike all other handlers.
This caused the request.id field to be silently omitted from audit log entries for all
help operations (e.g. vault path-help), making it impossible to correlate request and response entries in the audit log.

Fix this by setting that ID

Fixes #32026

@Flamefire
Flamefire requested a review from a team as a code owner July 2, 2026 15:50
@Flamefire
Flamefire requested a review from heatherezell July 2, 2026 15:50
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 2, 2026
@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

The `vercel.json` schema validation failed with the following message: should NOT have additional property `public`

Learn More: https://vercel.com/docs/concepts/projects/project-configuration

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vault-ui Error Error Jul 10, 2026 6:58am

Request Review

@dosubot dosubot Bot added the core/audit label Jul 2, 2026
@hashicorp-cla-app

hashicorp-cla-app Bot commented Jul 2, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 2, 2026
@Flamefire
Flamefire force-pushed the fix/help-audit-request-id branch from 194339b to f24ffd4 Compare July 3, 2026 07:28
@heatherezell

Copy link
Copy Markdown
Contributor

Hi there! Thanks for this fix. Please sign the CLA and ping me when that's done, so I can get this in front of engineers for review. :)

@Flamefire

Copy link
Copy Markdown
Author

@heatherezell Thought that went through already, done now

@heatherezell

Copy link
Copy Markdown
Contributor

@Flamefire It looks like you might have submitted a commit from either email or something else that GitHub doesn't see as connected to your GitHub account - can you take a peek?

The handleHelp function in http/help.go didn't set an ID unlike all other handlers.
This caused the request.id field to be silently omitted from audit log entries for all
help operations (e.g. `vault path-help`), making it impossible to correlate request and response entries in the audit log.
@Flamefire

Copy link
Copy Markdown
Author

What exactly are you referring to? All commits have the same email and all are with a GitHub registered email and shown as mine.
Anyway, I rebased to main to retrigger all checks and at least that CLA CI check is green, but that one has been green before.
Let me know if there is anything else that I might have missed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core/audit size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing request ID in audit entries for help requests

2 participants