This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Fix nil pointer dereference in auth config#4891
Open
izeau wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed some nil pointer dereference in the
deploystage using this (basic) configuration:It looks like the
pullImagefunction inbuiltin/docker/platform.gochecks if theauthblock is empty or not, but fails to check fornil. After taking a quick look around, I found this bug in 3 more cases. I applied the same reasoning as @catsby in e5b5fe9 to fix them.