Conversation
|
@kron-spar I updated this github action to use checkout v6 and setup-node v6 since they're the latest. It's passing and seems fine, but just wanted to pass this your way in case we're not using the latest on these for some reason. |
kron-spar
left a comment
kron-spar
left a comment
There was a problem hiding this comment.
These changes for the action look good to me!
aelkiss
left a comment
aelkiss
left a comment
There was a problem hiding this comment.
All seems fine to me; storybook looks good in chromatic. I didn't try anything locally.
| optimizeDeps: { | ||
| include: ['@storybook/svelte-vite', 'bootstrap', '@storybook/test'], | ||
| }, | ||
| // optimizeDeps: { |
There was a problem hiding this comment.
I noticed this area is commented out. Will these be revisited at a later time?
There was a problem hiding this comment.
Nah, I just forgot to delete it after testing the change worked.
A previous storybook migration added these lines, but this current Storybook migration threw errors about these lines while running tests. I commented them out to see if it broke anything and forgot to go back and delete before pushing to github.
Thanks for the note!
4 participants
The vite 7 upgrade was so easy in page turner yesterday that it got me thinking about firebird vite and storybook. So I did that today along with some other minor package bumps.
I was able to remove the custom plugin that was the workaround for our manifest file names.This turned out to be false. If we want to remove this custom plugin, we need to rewrite the functions that fetch the files from the manifest (thinking
/mdp-web/firebird/skeleton.xsl,catalog/interface/plugins/function.firebird_manifest.php,wordpress-hathitrust/functions.php,pt/web/firebird/.../main.svelte.js) to usestyle.cssinstead ofindex.css, which shouldn't be hard, and I should do that when we upgrade to vite 8.I also removed some ugly old path naming conventions and updated those with the node-native
import.meta.dirname(thanks, node 20/ESM!).The chromatic builds are passing, but I should test this on dev-3 before merging. Update: tested on dev-3 and everything is fine
Edit to add: the github action node version was 18 😱 So I updated that to 22 and the
checkoutandnode-setupactions versions to latest (v6 on both).Edit to add a celebration: we're finally back up to latest release on Storybook 🥳