Skip to content

adopt hightide 0.8.x#118

Open
DasProffi wants to merge 15 commits intomainfrom
adopt-hightide-0.8.x
Open

adopt hightide 0.8.x#118
DasProffi wants to merge 15 commits intomainfrom
adopt-hightide-0.8.x

Conversation

@DasProffi
Copy link
Member

No description provided.

@DasProffi DasProffi self-assigned this Feb 8, 2026
@DasProffi DasProffi marked this pull request as ready for review February 12, 2026 20:10
Comment on lines 486 to 491
<IconButton size="sm" onClick={handleExpandAll} tooltip={translation('expandAll')}>
<ChevronsDown className="size-4" />
</Button>
<Button layout="icon" size="sm" onClick={handleCollapseAll} title={translation('collapseAll')}>
</IconButton>
<IconButton size="sm" onClick={handleCollapseAll} tooltip={translation('collapseAll')}>
<ChevronsUp className="size-4" />
</Button>
</IconButton>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These buttons do not work anymore. Did the API got changed?

Copy link
Member

@felixevers felixevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an addition to the date form field.
The keyboard input is good.
But the tabulator Key mapping is broken. its necessary to be able to navigate using (reverse) tabbing.

Also the date input is still not localized (so not reacting to German for instance).

@DasProffi
Copy link
Member Author

Maybe an addition to the date form field. The keyboard input is good. But the tabulator Key mapping is broken. its necessary to be able to navigate using (reverse) tabbing.

Also the date input is still not localized (so not reacting to German for instance).

It is localized to the users OS locale by the browser.
If we were to enforce German or American format based on our configured locale value, we will need to write a custom date parser for all locale formats we want to support and also must write the input handling for auto completing and correcting and displaying ourself, which is quite difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants