fix(windows): preserve remote multiline paste

[akbash-bot]

Issue

A Windows user pastes multiline text with Shift+Insert or Shift+right-click during herdr --remote. The remote pane receives one wrapped block without line breaks.

Problem

Windows Terminal encoded each pasted newline as an Enter press and release report. The Windows client kept those reports as literal paste text instead of restoring the newline.

How did we fix it?

Herdr now converts the exact adjacent unmodified Enter press and release reports to one carriage return after a complete paste arrives. Other report-shaped paste text remains unchanged.

Verification

The reporter's exact input stream failed before because both Enter reports remained in the Paste event. The same test now emits one Paste with the expected line breaks, and the incomplete-pair test keeps unmatched reports unchanged. All 62 Windows input tests passed. just check passed formatting, Clippy, and 3,534 of 3,535 tests; the unrelated live-handoff process-discovery test still fails alone on this VPS.

refs #3209

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: b1060737-1f13-4630-81f6-6823a36b0984

📥 Commits

Reviewing files that changed from the base of the PR and between 99c23cd and f6f0e44.

📒 Files selected for processing (1)

• src/client/input/windows_vti.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• src/client/input/windows_vti.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

process_raw_events now decodes exact adjacent unmodified Windows Terminal Enter report pairs in Paste events as \r. It resets paste_from_win32_key_records for each Paste event. Tests cover complete report-pair decoding and preservation of incomplete pairs.

Suggested reviewers: pimpmuckl

Merge Risk: ⚪ Minimal · up to f6f0e

The change restores line breaks for completed multiline pastes on Windows while preserving unmatched report text, with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the Windows remote multiline paste fix, which matches the primary change.
Description check	✅ Passed	The description explains the Windows Terminal paste issue, the report-pair decoding fix, and verification results. It directly relates to the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[Pimpmuckl]

@greptileai

[greptile-apps]

Greptile Summary

This PR restores multiline Windows Terminal paste behavior for remote sessions by normalizing adjacent unmodified Enter press/release reports after a bracketed paste is fully parsed.

• Decodes each exact Enter report pair into one carriage return.
• Leaves incomplete and other report-shaped paste payloads unchanged.
• Adds regression coverage for multiline and incomplete-pair cases.

Confidence Score: 5/5

The PR appears safe to merge; the narrowly scoped normalization and regression tests preserve the intended normalized paste contract.

The changed path only transforms the exact adjacent Windows Terminal Enter press/release sequence after parsing a complete Paste event, while unmatched and differently shaped report payloads remain untouched.

Important Files Changed

Filename	Overview
src/client/input/windows_vti.rs	Normalizes exact Windows Terminal Enter report pairs inside completed paste events and adds focused regression tests without exposing a concrete correctness issue.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    A[Windows Terminal input] --> B[Windows VTI framing]
    B --> C[Complete bracketed Paste event]
    C --> D{Exact adjacent Enter press/release pair?}
    D -->|Yes| E[Replace pair with carriage return]
    D -->|No| F[Preserve payload]
    E --> G[Normalized client Paste event]
    F --> G

Loading

_{Reviews (1): Last reviewed commit: "fix(windows): preserve remote multiline ..." | Re-trigger Greptile}

[Pimpmuckl]

Manual verification completed on final head f6f0e44c:

• Rebased onto current master, including fix(windows): preserve native pane key identity #3503.
• Tested the Windows client over SSH to a disposable WSL Herdr server.
• Shift+Insert and Shift+right-click both preserved all three pasted lines.
• The pane produced - line one|- line two|- line three in both runs.
• Input traces contained \r separators between every line.

Focused tests, release build, CI, CodeRabbit, and Greptile are green.

[Pimpmuckl]

@akbash-bot could you check if this also fixed #3264 ?

[akbash-bot]

Yes. #3264 captured the same adjacent unmodified Enter pair that this PR normalizes:

ESC[13;28;13;1;0;1_ + ESC[13;28;13;0;0;1_

The normalization runs on the completed Windows Paste event before remote transport, so Ctrl+V versus Shift+Insert/right-click and --remote-keybindings mode do not change this path. I also reran the focused regression on current master; it passes. This fix covers #3264's leaked sequences and lost line breaks, so no separate code change is needed.