Move close(pipe_[]) from Teardown() to Deinitialize #1648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asopov-here
force-pushed
the
bug/NLAM-166-race-condition
branch
3 times, most recently
from
e0390a7 to
ce89cb5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1648 +/- ##
==========================================
+ Coverage 80.31% 80.34% +0.03%
==========================================
Files 350 350
Lines 14040 14039 -1
Branches 1514 1513 -1
==========================================
+ Hits 11276 11279 +3
+ Misses 2149 2146 -3
+ Partials 615 614 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asopov-here
force-pushed
the
bug/NLAM-166-race-condition
branch
2 times, most recently
from
96ad1bc to
3406d9a
Compare
andrey-kashcheev
previously approved these changes
Nov 27, 2025
khomenkd
previously approved these changes
Nov 27, 2025
It removes possibility close and write will appear simultaneously in different threads Relates-To: NLAM-166 Signed-off-by: Alexander Sopov <[email protected]>
asopov-here
force-pushed
the
bug/NLAM-166-race-condition
branch
from
3406d9a to
da5d21b
Compare
andrey-kashcheev
approved these changes
Nov 27, 2025
khomenkd
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It removes possibility close and write will appear simultaneously in different threads
Relates-To: NLAM-166