refactor: 25854 - clean up consensus fee tests

[ruslanvelkov-beep]

Description:

Redundant tests: ConsensusServiceFeesSuite.topicCreateBaseUSDFee() and AtomicConsensusServiceFeesSuite.topicCreateWithMultipleCustomFee() - 5-custom-fees create in atomic batch. Under Simple Fees the fee is a function of sigs + processing bytes only; the number of custom fees doesn't change the price.

ConsensusServiceFeesSuite contains the following tests:

• topicCreateBaseUSDFee (mentioned above) - tests topicCreate, topicCreateWithCustomFee, topicCreateWithMultipleCustomFees. First 2 are already covered by ConsensusServiceSimpleFeesSuite.{createTopicPlainComparison, createTopicCustomFeeComparison}, the last one is tested by TopicCreateCustomFeeSimpleFeesTest.topicCreateWithMultipleCustomFees.
• topicUpdateBaseUSDFee - covered by fees/ConsensusServiceSimpleFeesSuite.updateTopicComparison and hip1261/TopicUpdateSimpleFeesTest.
• topicDeleteBaseUSDFee - covered by fees/ConsensusServiceSimpleFeesSuite.deleteTopicPlainComparison and consensus/TopicDeleteSuite.
• topicSubmitMessageFeeScales - covered by hip1261/TopicSubmitMessageSimpleFeesTest (~24 cases, 50 bytes → 1024+ bytes).
• tokenGetTopicInfoBaseUSDFee - covered by fees/ConsensusServiceSimpleFeesSuite.getTopicInfoComparison.

AtomicConsensusServiceFeesSuite contains the following tests:

• topicCreateBaseUSDFee - covered by consensus/AtomicTopicCreateSuite.autoRenewAccountIdDoesNotNeedAdminKeyAutoRenewIsAlsoPayer{,_ECDSA,PrivateTopic} (three tests, all asserting expectedTopicCreateFullFeeUsd)
• topicCreateWithCustomFee - covered by the newly added test consensus/AtomicTopicCreateSuite.topicCreateWithCustomFeeInBatchChargesExpectedFee.
• topicCreateWithMultipleCustomFee (mentioned above) - no longer meaningful.
• topicUpdateBaseUSDFee - covered by hip1261/AtomicBatchCrossServiceSimpleFeesTest (lines 596, 1214, 1263) + hip1261/AtomicBatchNegativeSimpleFeesTest (line 1009).
• topicDeleteBaseUSDFee - covered by consensus/AtomicTopicDeleteSuite.topicDelete (validates expectedTopicDeleteFullFeeUsd).
• topicSubmitMessageBaseUSDFee - covered by hip1261/AtomicBatchBoundarySimpleFeesTest (lines 533, 604, 1135, 1143, 1151) + hip1261/AtomicBatchCrossServiceSimpleFeesTest (lines 1220, 1269) + hip1261/AtomicBatchNegativeSimpleFeesTest (line 980)

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[trunk-io]

Merging to main in this repository is managed by Trunk.

• To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

[lfdt-bot]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[ibankov]

Do we have coverage for the submit message transactions deleted from the consensus test suite?

[ruslanvelkov-beep]

Do we have coverage for the submit message transactions deleted from the consensus test suite?

Updated the PR description.

ConsensusServiceFeesSuite.topicSubmitMessageFeeScales is already covered by hip1261/TopicSubmitMessageSimpleFeesTest (~24 cases, 50 bytes → 1024+ bytes).

[testlens-app]

✅ All tests passed ✅

🏷️ Commit: abf33ee
▶️ Tests: 7054 executed
⚪️ Checks: 31/31 completed

---

Learn more about TestLens at testlens.app.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff              @@
##               main   #25965      +/-   ##
============================================
- Coverage     70.36%   70.36%   -0.01%     
+ Complexity    11823    11822       -1     
============================================
  Files          2627     2627              
  Lines        110235   110235              
  Branches      12097    12096       -1     
============================================
- Hits          77570    77565       -5     
- Misses        28663    28666       +3     
- Partials       4002     4004       +2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ibankov]

LGTM