Skip to content

Do not report 'Error when communicating with server' and similar errors triggered by user (browser) actions #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TDannhauer merged 1 commit into from
Feb 18, 2026
Merged

Do not report 'Error when communicating with server' and similar errors triggered by user (browser) actions #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions js/hordecore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,10 @@ var HordeCore = {
if (t.request.opts) {
this.endLoading(t.request.opts.loading);
}
this.notify(this.text.ajax_error, 'horde.error');
document.fire('HordeCore:ajaxFailure', [ t, o ]);
if (!t.request.aborted) {
this.notify(this.text.ajax_error, 'horde.error');
document.fire('HordeCore:ajaxFailure', [ t, o ]);
}
},

// opts: (Object) ajaxopts, callback, loading, uri
Expand Down
31 changes: 21 additions & 10 deletions js/prototype.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1635,9 +1635,7 @@ var Try = {
var Ajax = {
getTransport: function() {
return Try.these(
function() {return new XMLHttpRequest()},
function() {return new ActiveXObject('Msxml2.XMLHTTP')},
function() {return new ActiveXObject('Microsoft.XMLHTTP')}
function() { return new XMLHttpRequest() }
) || false;
},

Expand Down Expand Up @@ -1697,7 +1695,7 @@ Ajax.Base = Class.create({
}
});
Ajax.Request = Class.create(Ajax.Base, {
_complete: false,
aborted: false,

initialize: function($super, url, options) {
$super(options);
Expand Down Expand Up @@ -1734,6 +1732,10 @@ Ajax.Request = Class.create(Ajax.Base, {
if (this.options.asynchronous) this.respondToReadyState.bind(this).defer(1);

this.transport.onreadystatechange = this.onStateChange.bind(this);

this.transport.onabort = this.onAbort.bind(this);
this.transport.onloadend = this.onLoadEnd.bind(this);

this.setRequestHeaders();

this.body = this.method == 'post' ? (this.options.postBody || params) : null;
Expand All @@ -1751,8 +1753,16 @@ Ajax.Request = Class.create(Ajax.Base, {

onStateChange: function() {
var readyState = this.transport.readyState;
if (readyState > 1 && !((readyState == 4) && this._complete))
this.respondToReadyState(this.transport.readyState);
if (readyState > 1 && readyState < 4)
this.respondToReadyState(readyState);
},

onAbort: function() {
this.aborted = true;
},

onLoadEnd: function() {
this.respondToReadyState(4);
},

setRequestHeaders: function() {
Expand Down Expand Up @@ -1791,6 +1801,9 @@ Ajax.Request = Class.create(Ajax.Base, {
},

success: function() {
if (this.aborted)
return false;

var status = this.getStatus();
return !status || (status >= 200 && status < 300) || status == 304;
},
Expand All @@ -1806,8 +1819,9 @@ Ajax.Request = Class.create(Ajax.Base, {
var state = Ajax.Request.Events[readyState], response = new Ajax.Response(this);

if (state == 'Complete') {
this.transport.onreadystatechange = Prototype.emptyFunction;

try {
this._complete = true;
(this.options['on' + response.status]
|| this.options['on' + (this.success() ? 'Success' : 'Failure')]
|| Prototype.emptyFunction)(response, response.headerJSON);
Expand All @@ -1829,9 +1843,6 @@ Ajax.Request = Class.create(Ajax.Base, {
this.dispatchException(e);
}

if (state == 'Complete') {
this.transport.onreadystatechange = Prototype.emptyFunction;
}
},

isSameOrigin: function() {
Expand Down
Loading