Allow capturing dialog window content instead of Activities window - #216
Closed
AlanCornthwaiteKatalyst wants to merge 1 commit into
Closed
AlanCornthwaiteKatalyst wants to merge 1 commit into
AlanCornthwaiteKatalyst wants to merge 1 commit into
Conversation
AlanCornthwaiteKatalyst
force-pushed
the
capture-dialog-screen-on-dismiss
branch
from
September 11, 2026 06:26
97e093d to
f8cc4a6
Compare
Collaborator
|
Thank you for your contribution! I've included the changes in #217 which will be part of the next library release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue #150
The HotwireViewScreenshotHolder was using the Activity window to capture snapshots via PixelCopy. When a web view was inside a BottomSheetDialogFragment (which has its own Dialog and Window), the snapshotting process would accidentally capture the content of the Activity window sitting behind the bottom sheet at that same screen position. This resulted in the background content appearing in the foreground modal as it was dismissed.
The Fix