Repository navigation
Conversation
The custom entries view, the documentation window and the scrollbar floats were opened with relative='editor', i.e. at a cell of Neovim's screen. A GUI can show the editor area inside a larger screen (sidebars, panels, a status bar), so a screen cell is not a cell of the window's text: the menu opened away from the cursor, over the sidebar or at the bottom left of the window, and the docs and scrollbar followed the menu's screen cell instead of the menu. Open them with relative='win' anchored to the window they belong to, and place the entries in the window's cells (winline()/wincol() in insert mode; the command line keeps its screen position, which is the window's row below the text). The documentation window and the scrollbar use the entries window's space and measure the room to its right edge in the window. Neovim's own popup menu and the wildmenu view stay screen-relative, and the top half/bottom half fit checks are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom entries view, the documentation window and the scrollbar floats were opened with relative='editor', i.e. at a cell of Neovim's screen. A GUI can show the editor area inside a larger screen (sidebars, panels, a status bar), so a screen cell is not a cell of the window's text: the menu opened away from the cursor, over the sidebar or at the bottom left of the window, and the docs and scrollbar followed the menu's screen cell instead of the menu.
Open them with relative='win' anchored to the window they belong to, and place the entries in the window's cells (winline()/wincol() in insert mode; the command line keeps its screen position, which is the window's row below the text). The documentation window and the scrollbar use the entries window's space and measure the room to its right edge in the window.
Related: sassanh/qnvim#66