Skip to content

Screens/ScreenTabs: do not pass event codes to isalpha() #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenBE merged 1 commit into from
Sep 20, 2026
Merged

Screens/ScreenTabs: do not pass event codes to isalpha() #2116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ScreenTabsPanel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ static HandlerResult ScreenTabsPanel_eventHandler(Panel* super, int ch) {
break;
}
default:
if (ch < 255 && isalpha(ch))
if (0 < ch && ch < 255 && isalpha((unsigned char)ch))
result = Panel_selectByTyping(super, ch);
if (result == BREAK_LOOP)
result = IGNORED;
Expand Down Expand Up @@ -333,7 +333,7 @@ static HandlerResult ScreenNamesPanel_eventHandlerNormal(Panel* super, int ch) {
result = HANDLED;
break;
default:
if (ch < 255 && isalpha(ch))
if (0 < ch && ch < 255 && isalpha((unsigned char)ch))
result = Panel_selectByTyping(super, ch);
if (result == BREAK_LOOP)
result = IGNORED;
Expand Down
2 changes: 1 addition & 1 deletion ScreensPanel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ static HandlerResult ScreensPanel_eventHandlerNormal(Panel* super, int ch) {
result = HANDLED;
break;
default:
if (ch < 255 && isalpha(ch))
if (0 < ch && ch < 255 && isalpha((unsigned char)ch))
result = Panel_selectByTyping(super, ch);
if (result == BREAK_LOOP)
result = IGNORED;
Expand Down
Loading