Add English localization via String Catalog#2
Open
dboleslawski wants to merge 1 commit intohuberdf:mainfrom
Open
Add English localization via String Catalog#2dboleslawski wants to merge 1 commit intohuberdf:mainfrom
dboleslawski wants to merge 1 commit intohuberdf:mainfrom
Conversation
Introduces Localizable.xcstrings and InfoPlist.xcstrings. Source language stays Simplified Chinese; English is added as a translation so the UI renders in the user's preferred macOS language. - Localizable.xcstrings: ~130 UI strings translated - InfoPlist.xcstrings: localizes the screen recording usage description - String(localized:) wrapping for strings stored in @State / computed properties / service return values (error messages, preset names, "内建显示屏", color space descriptions) - Text(LocalizedStringKey(var)) and .help(LocalizedStringKey(var)) for custom views that pass String labels to child Text (AdjustRow, actionButton, IconOptionButton, ExpandableRow) - SectionBadge.title and TagBadge.text switched to LocalizedStringKey No behavioral changes. Build produces zh-Hans.lproj and en.lproj.
|
Thanks for doing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Localizable.xcstringsandInfoPlist.xcstrings, adding English as a translation alongside the existing Chinese UIWhat changed
FreeDisplay/Resources/Localizable.xcstrings— ~130 UI strings with English translationsFreeDisplay/Resources/InfoPlist.xcstrings— localizes the screen recording permission descriptionString(localized:),LocalizedStringKeywrapping) in places where strings were stored in@State/ computed properties / service return values — needed because those paths don't auto-localize through SwiftUI'sTextoverloadproject.pbxprojregenerated viaxcodegento include the new resource filesTest plan
xcodebuild -scheme FreeDisplay -configuration Debug build— passes (warnings unchanged from main).appships bothzh-Hans.lprojanden.lprojunderContents/Resources/open --args -AppleLanguages '(en)'— menu renders in English