Remove calls to the deprecated llama_set_warmup - #205
Merged
Conversation
mattt
reviewed
Sep 2, 2026
mattt
left a comment
mattt
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, @james-333i. One small thing before I merge: removing the llama_set_warmup line left the next line over-indented, and CI runs swift format lint --strict, so this fails the Lint step. Accepting the suggestion below should do it.
Co-authored-by: Mattt <mattt@me.com>
Collaborator
|
Merging now. Thanks, @james-333i! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current llama.cpp builds deprecate
llama_set_warmup(TAG_LLAMA_GRAPH_NO_WARMUP). Warmup no longer runs implicitly, so calling it withfalseis a no-op, and the header notes the function will be removed.This removes both call sites in
LlamaLanguageModel. There is no behavior change