add post init for safty checker #12794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiqing-feng <[email protected]>
sayakpaul
reviewed
Dec 5, 2025
|
|
||
| self.concept_embeds_weights = nn.Parameter(torch.ones(17), requires_grad=False) | ||
| self.special_care_embeds_weights = nn.Parameter(torch.ones(3), requires_grad=False) | ||
| self.post_init() |
Member
There was a problem hiding this comment.
Should we condition this based on the transformers version being used?
Contributor
Author
There was a problem hiding this comment.
Maybe better to use try except?
Member
There was a problem hiding this comment.
IMO, opinion it's better to be explicit about conditioning with versioning since we know that it's a versioning problem.
Contributor
Author
|
Hi @sayakpaul . Please let me know what needs to be changed before merging. Thanks! |
sayakpaul
approved these changes
Dec 8, 2025
Member
|
@bot /style |
Contributor
|
Style bot fixed some files and pushed the changes. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
Thanks! |
Signed-off-by: jiqing-feng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix safety checker loading issue: huggingface/transformers#42544 .
Hi @sayakpaul . Please review this PR. Thanks!