fix/lmstudio-numeric-password-mcp - #172
Open
david-hummingbot wants to merge 3 commits into
Open
Conversation
Ensure all arguments and environment variables are strings.
Refactor to use _hummingbot_mcp_args for argument construction.
Add test for handling numeric credentials in MCP args.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
username/password(and related CLI args) to strings when building stdio server configs, so YAML-loaded numeric credentials (e.g.password: 123456) don’t break agent startup.PydanticAIClientby stringifying MCPargs/envbeforeStdioServerParametersvalidation — the failure path used bylmstudio:/ollama:/ other pydantic-ai backends.Root cause
Unquoted numeric passwords in
config.yml(often written bysetup-environment.sh) load asint. Starting an LM Studio (pydantic-ai) session validates MCP args strictly and fails with:StdioServerParameters.args.9 … input_value=123456, input_type=intACP agents don’t hit the same validation, so the bug mainly shows up with local LLMs.
Test plan
servers.local.password: 123456(unquoted) inconfig.yml, restart Condor, start/agentwith LM Studio — session should start (noStdioServerParameterserror)