Open
Conversation
Changing README challenge description for the requested challenge. Listed an high level overview of what has to be done to build the deliverable.
Web application build with Ruby on Rails, nginx andDocker/docker-compose setup
Setup rspec, rubocop and fix rubocop offenses
An high level test scenarios that will guide my develompent classes
Config of a controller to receive and validate a file format. Installation of webpacker to enable views
Mock a few data on service response to build a view with that data
Creates a card model with an interface for instantiating objects and validating inputs
Enables hand evaluator to check all hands picking the best of them
Splitted hand evaluation between classes. Evaluation occurs in order of priority and returns as soon as it finds the best hand
Data showing in one line per game. Error messages shown below file input. Rubocop offenses fixed
luxu
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My Solution
Setup
Project dependencies
dockerdocker-composeContainer setup
Build the containers for the application
Install webpacker
Running the application
Let docker compose do the job for us
Testing
Run tests using rspec
Code Linter
Code quality evaluation is available with rubocop
The application will be accessible on
localhost:3000Personal Notes
ToDos