Skip to content

feat: use text index to power filters and autocomplete #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knudtty wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: use text index to power filters and autocomplete #2376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f1696bb
feat: adds direct_read optimization by default for logs and traces
knudtty May 26, 2026
a83332f
fix: version guard only applies for ALIAS columns
knudtty May 26, 2026
671029b
fix: add compat schema for traces
knudtty May 26, 2026
45211c8
Merge branch 'main' into aaron/fts-for-26-4
knudtty May 26, 2026
6fe6c2e
feat: use text indexes to power filter and autocomplete
knudtty May 29, 2026
7e407ed
Merge remote-tracking branch 'origin/main' into aaron/fts-index-as-ag…
knudtty May 29, 2026
ae2beeb
fix: cleanup
knudtty May 29, 2026
5dc9015
fix tests
knudtty May 29, 2026
36244d0
fix: date range in cache key if no metadataMVs
knudtty Jun 1, 2026
9f8ee50
fix: use query date range + timestamp to get part names from table di…
knudtty Jun 1, 2026
c5a96e2
fix tests
knudtty Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/common-utils/src/__tests__/clickhouseVersion.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
isClickHouseVersionAtLeast,
parseClickHouseVersion,
supportsDirectReadMap,
supportsMergeTreeTextIndex,
} from '@/core/clickhouseVersion';

type ClickHouseVersionTuple = readonly [number, number, number, number];
Expand Down Expand Up @@ -174,3 +175,24 @@ describe('supportsDirectReadMap', () => {
expect(supportsDirectReadMap(undefined)).toBe(false);
});
});

describe('supportsMergeTreeTextIndex', () => {
it.each<readonly [ClickHouseVersionTuple, boolean]>([
[[26, 3, 0, 0], true],
[[26, 3, 0, 1], true],
[[26, 3, 99, 99], true],
[[26, 4, 0, 0], true],
[[27, 0, 0, 0], true],
[[26, 2, 99, 99], false],
[[26, 2, 0, 0], false],
[[26, 1, 0, 0], false],
[[25, 12, 0, 0], false],
[[24, 0, 0, 0], false],
])('%j → %s', (version, expected) => {
expect(supportsMergeTreeTextIndex(version)).toBe(expected);
});

it('returns false when the version is undefined', () => {
expect(supportsMergeTreeTextIndex(undefined)).toBe(false);
});
});
Loading
Loading