Skip to content

Fix manifest.json artifact upload in workflow #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dan-r wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −12
Open

Fix manifest.json artifact upload in workflow #1771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions .github/workflows/docker_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
runs-on: ubuntu-latest
permissions:
packages: write
contents: write
steps:
- uses: actions/checkout@v7.0.0
with:
Expand Down Expand Up @@ -63,22 +64,22 @@ jobs:
- name: Set latest tag
if: github.event.action == 'released' && github.ref_name == env.LATEST_TAG
run: |
echo "DOCKER_TAGS=${{ env.DOCKER_TAGS }},ghcr.io/${{ github.repository }}:latest" >> $GITHUB_ENV
echo "DOCKER_TAGS=${DOCKER_TAGS:+$DOCKER_TAGS,}ghcr.io/${{ github.repository }}:latest" >> $GITHUB_ENV

- name: Set alpha tag
if: github.event.action == 'prereleased' && contains(github.ref, 'alpha')
run: |
echo "DOCKER_TAGS=${{ env.DOCKER_TAGS }},ghcr.io/${{ github.repository }}:alpha" >> $GITHUB_ENV
echo "DOCKER_TAGS=${DOCKER_TAGS:+$DOCKER_TAGS,}ghcr.io/${{ github.repository }}:alpha" >> $GITHUB_ENV

- name: Set beta tag
if: github.event.action == 'prereleased' && contains(github.ref, 'beta')
run: |
echo "DOCKER_TAGS=${{ env.DOCKER_TAGS }},ghcr.io/${{ github.repository }}:beta" >> $GITHUB_ENV
echo "DOCKER_TAGS=${DOCKER_TAGS:+$DOCKER_TAGS,}ghcr.io/${{ github.repository }}:beta" >> $GITHUB_ENV

- name: Set rc tag
if: github.event.action == 'prereleased' && contains(github.ref, 'rc')
run: |
echo "DOCKER_TAGS=${{ env.DOCKER_TAGS }},ghcr.io/${{ github.repository }}:rc" >> $GITHUB_ENV
echo "DOCKER_TAGS=${DOCKER_TAGS:+$DOCKER_TAGS,}ghcr.io/${{ github.repository }}:rc" >> $GITHUB_ENV

- name: Set build tag
id: build_tag_generator
Expand Down Expand Up @@ -110,7 +111,7 @@ jobs:
builder: ${{ steps.buildx.outputs.name }}
push: true
platforms: linux/amd64
tags: ghcr.io/${{ github.repository }}:${{ steps.build_tag_generator.outputs.RELEASE_TAG }},ghcr.io/${{ github.repository }}:head,${{ env.DOCKER_TAGS }}
tags: ghcr.io/${{ github.repository }}:${{ steps.build_tag_generator.outputs.RELEASE_TAG }},ghcr.io/${{ github.repository }}:head${{ env.DOCKER_TAGS && format(',{0}', env.DOCKER_TAGS) || '' }}
labels: |
commit=${{ github.sha }}
build_date=${{ steps.build_tag_generator.outputs.BUILD_DATE }}
Expand All @@ -130,11 +131,7 @@ jobs:

- name: Upload manifest.json to GitHub Release
if: github.event_name == 'release'
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
uses: softprops/action-gh-release@v3

@EnriqueL8 EnriqueL8 Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is softprops? Why are we not using the official actions?

@dan-r dan-r Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its recommended by the GitHub team as a replacement for the discontinued action https://github.com/actions/upload-release-asset

Please note: This repository is currently unmaintained by a team of developers at GitHub. The repository is here and you can use it as an example, or in Actions. However please be aware that we are not going to be updating issues or pull requests on this repository.

Maintained Actions:

softprops/action-gh-release

with:
upload_url: ${{ github.event.release.upload_url }}
asset_path: ./manifest.json
asset_name: manifest.json
asset_content_type: application/json
tag_name: ${{ github.event.release.tag_name }}
files: ./manifest.json