Repository navigation
IBX-11939: Replaced SqlPlatform with doctrine-schema's DatabasePlatformName - #154
Merged
Steveb-p merged 3 commits intoSep 30, 2026
Merged
Conversation
…rmName ibexa/doctrine-migrations is dropping SqlPlatform in favour of DatabasePlatformName (IBX-12043).
…rations without SqlPlatform Points CI at the IBX-12043-replace-sql-platform-with-database-platform-name-5.0 branch, which removes SqlPlatform, so this PR's tests can run before that change merges. Must be removed before merging.
Steveb-p
marked this pull request as ready for review
September 30, 2026 11:55
ibexa-workflow-automation-1
Bot
requested review from
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
September 30, 2026 11:56
konradoboza
approved these changes
Sep 30, 2026
tbialcz
approved these changes
Sep 30, 2026
Contributor
|
+1 if CI goes green |
barw4
approved these changes
Sep 30, 2026
|
Steveb-p
added a commit
that referenced
this pull request
Oct 1, 2026
Steveb-p
added a commit
that referenced
this pull request
Oct 1, 2026
Steveb-p
added a commit
that referenced
this pull request
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
ibexa/doctrine-migrations#17 drops
SqlPlatformin favour of doctrine-schema'sDatabasePlatformName, so this switches theabortIfUnsupportedPlatform()calls over. It's split out of #129 so that one keeps building against the current doctrine-migrations until #17 lands.On 5.0
DatabasePlatformNameis an enum, henceMySQL/PostgreSQL/SQLiteinstead of 4.6'sMYSQL/POSTGRESQL/SQLITE. This also converts the migrations that came in from 4.6, so once #153 (the 4.6 counterpart) is in and #129's base gets re-merged, those lines will conflict. Keep the 5.0 spelling.