Add support for old Info-ZIP extra block for Unix#660
Open
bastianeicher wants to merge 1 commit intoicsharpcode:masterfrom
Open
Add support for old Info-ZIP extra block for Unix#660bastianeicher wants to merge 1 commit intoicsharpcode:masterfrom
bastianeicher wants to merge 1 commit intoicsharpcode:masterfrom
Conversation
…x Extra Field type 1)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 73.28% 73.04% -0.25%
==========================================
Files 68 68
Lines 8304 8339 +35
==========================================
+ Hits 6086 6091 +5
- Misses 2218 2248 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
piksel
reviewed
Sep 19, 2021
Member
piksel
left a comment
piksel
left a comment
There was a problem hiding this comment.
This looks overall good, but there are no tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SharpZipLib currently supports reading timestamps from the "Extended Timestamp Extra Field" (
0x5455).This PR adds support for the older (but still often seen in new
.zipfiles) "Info-ZIP Unix Extra Field (type 1)" (0x5855).I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.